invoice-front.js ➔ jQuery - Code Metrics - Inspection of "Payment gateways should be hidden if invoice total..." - AyeCode/invoicing - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#43)

by Kiran

created 2017-07-21 09:22 UTC

invoice-front.js ➔ jQuery B

↳ Parent: assets/js/invoice-front.js

Complexity

Conditions	1
Paths	24

Size

Total Lines

271

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	24
nop	1
dl	0
loc	271
rs	8.2857
c	0
b	0
f	0

8 Functions

Rating	Name	Size	Complexity
B	invoice-front.js ➔ ... ➔ $(ꞌ#wpinv_checkout_formꞌ).submit	43	4
B	invoice-front.js ➔ ... ➔ WPInv_Checkout.init_payment_methods	30	3
B	invoice-front.js ➔ ... ➔ $.change	31	1
A	invoice-front.js ➔ ... ➔ WPInv_Checkout.init	9	2
A	invoice-front.js ➔ ... ➔ WPInv_Checkout.recalculate_taxes	4	1
A	invoice-front.js ➔ ... ➔ WPInv_Checkout.applyDiscount	69	2
C	invoice-front.js ➔ ... ➔ WPInv_Checkout.payment_method_selected	23	8
A	invoice-front.js ➔ ... ➔ WPInv_Checkout.removeDiscount	49	2

How to fix Long Method

// make sure ajaxurl is defined
if (typeof ajaxurl === 'undefined' || ajaxurl === null) {

    // variable is undefined or null
    ajaxurl = WPInv.ajax_url;

}
window.wpiSubmit = typeof window.wpiSubmit !== 'undefined' ? window.wpiSubmit : true;
jQuery(function($) {
    var valid = false;
    $('#wpinv_checkout_form').on('submit', function(e) {
        var $form = $(this).closest('#wpinv_checkout_form');
        $('.wpinv_errors').remove();
        if (valid) {
            return true;
        }
        var fields = ['first_name', 'email', 'address', 'city', 'country', 'state'];
        var err = [];
        $.each(fields, function(i, field) {
            if ($('#wpinv_' + field).length && !$('#wpinv_' + field).val()) {
                err.push(field);
            }
        });
        if (err && err.length > 0) {
            $('#wpinv_' + err[0]).focus();
            return false;
        } else {
            e.preventDefault();
            wpinvBlock($form);
            var data = $form.serialize();
            data = wpinvRemoveQueryVar(data, 'action');
            data = wpinvRemoveQueryVar(data, 'wpinv_ajax');
            $.post(ajaxurl, data + '&action=wpinv_checkout', function(res) {

                if (res && typeof res == 'object' && res.success) {
                    valid = true;
                    var data = new Object();
                    data.form = $form;
                    data.totals = res.data;
                    jQuery('body').trigger('wpinv_checkout_submit', data);
                    if (window.wpiSubmit) {
                        $form.submit();
                    }
                } else {
                    $form.unblock();
                    if (res && res.search("wpinv_adddress_confirm") !== -1) {
                        $('#wpinv_adddress_confirm').show();
                    }
                    $('#wpinv_purchase_submit', $form).before(res);
                }
            });
        }
        return false;
    });
    var elB = $('#wpinv-fields');
    $('#wpinv_country', elB).change(function(e) {

        $('.wpinv_errors').remove();
        wpinvBlock(jQuery('#wpinv_state_box'));
        var $this = $(this);

        data = {

            action: 'wpinv_get_states_field',
            country: $(this).val(),
            field_name: 'wpinv_state',
        };
        $.post(ajaxurl, data, function(response) {

            if ('nostates' === response) {
                var text_field = '<input type="text" required="required" class="wpi-input required" id="wpinv_state" name="wpinv_state">';
                $('#wpinv_state', elB).replaceWith(text_field);
            } else {
                $('#wpinv_state', elB).replaceWith(response);
                var changeState = function() {
                    console.log('69 : wpinv_recalculate_taxes(' + $(this).val() + ')');

                    wpinv_recalculate_taxes($(this).val());
                };
                $("#wpinv_state").unbind("change", changeState);
                $("#wpinv_state").bind("change", changeState);
            }
            $('#wpinv_state', elB).find('option[value=""]').remove();
            $('#wpinv_state', elB).addClass('form-control wpi-input required');
        }).done(function(data) {

            jQuery('#wpinv_state_box').unblock();
            console.log('78 : wpinv_recalculate_taxes()');

            wpinv_recalculate_taxes();
        });
        return false;
    });
    $('select#wpinv_state', elB).change(function(e) {

        $('.wpinv_errors').remove();
        console.log('86 : wpinv_recalculate_taxes()');

        wpinv_recalculate_taxes($(this).val());
    });
    var WPInv_Checkout = {
        checkout_form: $('form#wpinv_checkout_form'),
        init: function() {
            if (!$(this.checkout_form).length) {
                return;
            }
            // Payment methods
            this.checkout_form.on('click', 'input[name="wpi-gateway"]', this.payment_method_selected);
            this.init_payment_methods();
            //this.recalculate_taxes();
        },
        init_payment_methods: function() {
            var $checkout_form = this.checkout_form;
            var $payment_methods = $('.wpi-payment_methods input[name="wpi-gateway"]');
            // If there is one method, we can hide the radio input
            if (1 === $payment_methods.length) {
                $payment_methods.eq(0).hide();
            }
            // If there are none selected, select the first.
            if (0 === $payment_methods.filter(':checked').length) {
                $payment_methods.eq(0).prop('checked', true);
            }
            // Trigger click event for selected method
            $payment_methods.filter(':checked').eq(0).trigger('click');
            // Validate and apply a discount
            $checkout_form.on('click', '#wpi-apply-discount', this.applyDiscount);
            // Prevent the checkout form from submitting when hitting enter key in the discount field
            $checkout_form.on('keypress', '#wpinv_discount_code', function(event) {
                if (event.keyCode == '13') {
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
                    return false;
                }
            });
            // Apply the discount when hitting enter key in the discount field instead
            $checkout_form.on('keyup', '#wpinv_discount_code', function(event) {
                if (event.keyCode == '13') {
                    $('#wpi-apply-discount', $checkout_form).trigger('click');
                }
            });
            // Remove a discount
            $(document.body).on('click', '.wpi-discount-remove', this.removeDiscount);
        },
        payment_method_selected: function() {
            if ($('.wpi-payment_methods input.wpi-pmethod').length > 1) {
                var target_payment_box = $('div.payment_box.' + $(this).attr('ID'));
                if ($(this).is(':checked') && !target_payment_box.is(':visible')) {
                    $('div.payment_box').filter(':visible').slideUp(250);
                    if ($(this).is(':checked')) {
                        var content = $('div.payment_box.' + $(this).attr('ID')).html();
                        content = content ? content.trim() : '';
                        if (content) {
                            $('div.payment_box.' + $(this).attr('ID')).slideDown(250);
                        }
                    }
                }
            } else {
                $('div.payment_box').show();
            }
            $('#wpinv_payment_mode_select').attr('data-gateway', $(this).val());
            if ($(this).data('button-text')) {
                $('#wpinv-payment-button').val($(this).data('button-text'));
            } else {
                $('#wpinv-payment-button').val($('#wpinv-payment-button').data('value'));
            }
        },
        applyDiscount: function(e) {

            e.preventDefault();
            var $this = $(this),
                $box = $this.closest('.panel-body'),
                discount_code = $('#wpinv_discount_code', $box).val(),
                $msg = $('.wpinv-discount-msg', $box),
                $msgS = $('.alert-success', $msg),
                $msgF = $('.alert-error', $msg);
            if (discount_code == '') {
                $('#wpinv_discount_code', $box).focus();
                return false;
            }
            var data = {
                action: 'wpinv_apply_discount',
                code: discount_code,
                _nonce: WPInv.nonce

            };
            $('.wpinv_errors').remove();
            $msg.hide();
            $msgS.hide().find('.wpi-msg').html('');
            $msgF.hide().find('.wpi-msg').html('');
            wpinvBlock($box);
            $.ajax({
                type: "POST",
                data: data,
                dataType: "json",
                url: WPInv.ajax_url,
                xhrFields: {
                    withCredentials: true
                },
                success: function(res) {
                    wpinvUnblock($box);
                    var success = false;
                    if (res && typeof res == 'object') {
                        if (res.success) {
                            success = true;
                            jQuery('#wpinv_checkout_cart_form', $this.checkout_form).replaceWith(res.data.html);
                            jQuery('.wpinv-chdeckout-total').text(res.data.total);
                            $('#wpinv_discount_code', $box).val('');
                            //console.log('217 : wpinv_recalculate_taxes()');
                            //wpinv_recalculate_taxes();
                            if (res.data.free) {
                                $('#wpinv_payment_mode_select', $this.checkout_form).hide();
                                gw = 'manual';

                            } else {
                                $('#wpinv_payment_mode_select', $this.checkout_form).show();
                                gw = $('#wpinv_payment_mode_select', $this.checkout_form).data('gateway');
                            }
                            $('input[name="wpi-gateway"]', $this.checkout_form).val(gw);
                            $(document.body).trigger('wpinv_discount_applied', [res]);
                        }
                        if (res.msg) {
                            $msg.show();
                            if (success) {
                                $msgS.show().find('.wpi-msg').html(res.msg);
                            } else {
                                $msgF.show().find('.wpi-msg').html(res.msg);
                            }
                        }
                    }
                }
            }).fail(function(res) {
                wpinvUnblock($box);
                if (window.console && window.console.log) {
                    console.log(res);

                }
            });
            return false;
        },
        removeDiscount: function(e) {

            e.preventDefault();
            var $this = $(this),
                $block = $this.closest('#wpinv_checkout_cart_wrap'),
                discount_code = $this.data('code');
            if (discount_code == '') {
                return false;
            }
            var data = {
                action: 'wpinv_remove_discount',
                code: discount_code,
                _nonce: WPInv.nonce

            };
            wpinvBlock($block);
            $.ajax({
                type: "POST",
                data: data,
                dataType: "json",
                url: WPInv.ajax_url,
                xhrFields: {
                    withCredentials: true
                },
                success: function(res) {
                    if (res && typeof res == 'object') {
                        if (res.success) {
                            jQuery('#wpinv_checkout_cart_form', $this.checkout_form).replaceWith(res.data.html);
                            jQuery('.wpinv-chdeckout-total').text(res.data.total);
                            if (res.data.free) {
                                $('#wpinv_payment_mode_select', $this.checkout_form).hide();
                                gw = 'manual';

                            } else {
                                $('#wpinv_payment_mode_select', $this.checkout_form).show();
                                gw = $('#wpinv_payment_mode_select', $this.checkout_form).data('gateway');
                            }
                            $('input[name="wpi-gateway"]', $this.checkout_form).val(gw);
                            //console.log('291 : wpinv_recalculate_taxes()');
                            //wpinv_recalculate_taxes();
                            $(document.body).trigger('wpinv_discount_removed', [res]);
                        }
                    }
                }
            }).fail(function(res) {
                wpinvUnblock($block);
                if (window.console && window.console.log) {
                    console.log(res);

                }
            });
            return false;
        },
        recalculate_taxes: function() {
            console.log('308 : wpinv_recalculate_taxes()');

            wpinv_recalculate_taxes();
        }
    }
    WPInv_Checkout.init();
});

function wpinvBlock(el, message) {
    message = typeof message != 'undefined' && message !== '' ? '&nbsp;' + message : '';
    el.block({
        message: '<i class="fa fa-refresh fa-spin"></i>' + message,
        overlayCSS: {
            background: '#fff',
            opacity: 0.6
        },
        ignoreIfBlocked: true
    });
}

function wpinvUnblock(el) {
    el.unblock();
}

function wpinvRemoveQueryVar(url, parameter) {
    //prefer to use l.search if you have a location/link object
    var urlparts = url.split('?');
    var urlparts2 = url.split('&');
    if (urlparts.length >= 2) {
        var prefix = encodeURIComponent(parameter) + '=';
        var pars = urlparts[1].split(/[&;]/g);
        //reverse iteration as may be destructive
        for (var i = pars.length; i-- > 0;) {
            //idiom for string.startsWith
            if (pars[i].lastIndexOf(prefix, 0) !== -1) {
                pars.splice(i, 1);
            }
        }
        url = urlparts[0] + (pars.length > 0 ? '?' + pars.join('&') : "");
        return url;
    } else if (urlparts2.length >= 2) {
        var prefix = encodeURIComponent(parameter) + '=';

        var pars = url.split(/[&;]/g);

        //reverse iteration as may be destructive
        for (var i = pars.length; i-- > 0;) {

            //idiom for string.startsWith
            if (pars[i].lastIndexOf(prefix, 0) !== -1) {
                pars.splice(i, 1);
            }
        }
        url = pars.join('&');
        return url;
    } else {
        return url;
    }
}

1			// make sure ajaxurl is defined
2			if (typeof ajaxurl === 'undefined' \|\| ajaxurl === null) {
			0 ignored issues – show Bug introduced 2017-06-23 11:56 UTC by Report Bug Copy Issue Report The variable `ajaxurl` seems to be never declared. If this is a global, consider adding a `/** global: ajaxurl */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
3			// variable is undefined or null
4			ajaxurl = WPInv.ajax_url;
			0 ignored issues – show Bug introduced 2017-06-23 11:56 UTC by Report Bug Copy Issue Report The variable `WPInv` seems to be never declared. If this is a global, consider adding a `/** global: WPInv */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history... Bug introduced 2017-06-23 11:56 UTC by Report Bug Copy Issue Report The variable `ajaxurl` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.ajaxurl`. Loading history...
5			}
6			window.wpiSubmit = typeof window.wpiSubmit !== 'undefined' ? window.wpiSubmit : true;
7			jQuery(function($) {
8			var valid = false;
9			$('#wpinv_checkout_form').on('submit', function(e) {
10			var $form = $(this).closest('#wpinv_checkout_form');
11			$('.wpinv_errors').remove();
12			if (valid) {
13			return true;
14			}
15			var fields = ['first_name', 'email', 'address', 'city', 'country', 'state'];
16			var err = [];
17			$.each(fields, function(i, field) {
18			if ($('#wpinv_' + field).length && !$('#wpinv_' + field).val()) {
19			err.push(field);
20			}
21			});
22			if (err && err.length > 0) {
23			$('#wpinv_' + err[0]).focus();
24			return false;
25			} else {
26			e.preventDefault();
27			wpinvBlock($form);
28			var data = $form.serialize();
29			data = wpinvRemoveQueryVar(data, 'action');
30			data = wpinvRemoveQueryVar(data, 'wpinv_ajax');
31			$.post(ajaxurl, data + '&action=wpinv_checkout', function(res) {
			0 ignored issues – show Bug introduced 2017-06-23 11:56 UTC by Report Bug Copy Issue Report The variable `ajaxurl` does not seem to be initialized in case `typeof ajaxurl === "und...ed" \|\| ajaxurl === null` on line `2` is `false`. Are you sure the function `post` handles `undefined` variables? Loading history...
32			if (res && typeof res == 'object' && res.success) {
33			valid = true;
34			var data = new Object();
35			data.form = $form;
36			data.totals = res.data;
37			jQuery('body').trigger('wpinv_checkout_submit', data);
38			if (window.wpiSubmit) {
39			$form.submit();
40			}
41			} else {
42			$form.unblock();
43			if (res && res.search("wpinv_adddress_confirm") !== -1) {
44			$('#wpinv_adddress_confirm').show();
45			}
46			$('#wpinv_purchase_submit', $form).before(res);
47			}
48			});
49			}
50			return false;
51			});
52			var elB = $('#wpinv-fields');
53			$('#wpinv_country', elB).change(function(e) {
			0 ignored issues – show Unused Code introduced 2017-06-23 11:56 UTC by Report Bug Copy Issue Report The parameter `e` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
54			$('.wpinv_errors').remove();
55			wpinvBlock(jQuery('#wpinv_state_box'));
56			var $this = $(this);
			0 ignored issues – show Unused Code introduced 2017-06-23 11:56 UTC by Report Bug Copy Issue Report The variable `$this` seems to be never used. Consider removing it. Loading history...
57			data = {
			0 ignored issues – show Bug introduced 2017-06-23 11:56 UTC by Report Bug Copy Issue Report The variable `data` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.data`. Loading history...
58			action: 'wpinv_get_states_field',
59			country: $(this).val(),
60			field_name: 'wpinv_state',
61			};
62			$.post(ajaxurl, data, function(response) {
			0 ignored issues – show Bug introduced 2017-06-23 11:56 UTC by Report Bug Copy Issue Report The variable `ajaxurl` does not seem to be initialized in case `typeof ajaxurl === "und...ed" \|\| ajaxurl === null` on line `2` is `false`. Are you sure the function `post` handles `undefined` variables? Loading history...
63			if ('nostates' === response) {
64			var text_field = '<input type="text" required="required" class="wpi-input required" id="wpinv_state" name="wpinv_state">';
65			$('#wpinv_state', elB).replaceWith(text_field);
66			} else {
67			$('#wpinv_state', elB).replaceWith(response);
68			var changeState = function() {
69			console.log('69 : wpinv_recalculate_taxes(' + $(this).val() + ')');
			0 ignored issues – show Debugging Code introduced 2017-06-23 11:56 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
70			wpinv_recalculate_taxes($(this).val());
71			};
72			$("#wpinv_state").unbind("change", changeState);
73			$("#wpinv_state").bind("change", changeState);
74			}
75			$('#wpinv_state', elB).find('option[value=""]').remove();
76			$('#wpinv_state', elB).addClass('form-control wpi-input required');
77			}).done(function(data) {
			0 ignored issues – show Unused Code introduced 2017-06-23 11:56 UTC by Report Bug Copy Issue Report The parameter `data` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
78			jQuery('#wpinv_state_box').unblock();
79			console.log('78 : wpinv_recalculate_taxes()');
			0 ignored issues – show Debugging Code introduced 2017-06-23 11:56 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
80			wpinv_recalculate_taxes();
81			});
82			return false;
83			});
84			$('select#wpinv_state', elB).change(function(e) {
			0 ignored issues – show Unused Code introduced 2017-06-23 11:56 UTC by Report Bug Copy Issue Report The parameter `e` is not used and could be removed. This check looks for parameters in functions that are not used in the function body and are not followed by other parameters which are used inside the function. Loading history...
85			$('.wpinv_errors').remove();
86			console.log('86 : wpinv_recalculate_taxes()');
			0 ignored issues – show Debugging Code introduced 2017-06-23 11:56 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
87			wpinv_recalculate_taxes($(this).val());
88			});
89			var WPInv_Checkout = {
90			checkout_form: $('form#wpinv_checkout_form'),
91			init: function() {
92			if (!$(this.checkout_form).length) {
93			return;
94			}
95			// Payment methods
96			this.checkout_form.on('click', 'input[name="wpi-gateway"]', this.payment_method_selected);
97			this.init_payment_methods();
98			//this.recalculate_taxes();
99			},
100			init_payment_methods: function() {
101			var $checkout_form = this.checkout_form;
102			var $payment_methods = $('.wpi-payment_methods input[name="wpi-gateway"]');
103			// If there is one method, we can hide the radio input
104			if (1 === $payment_methods.length) {
105			$payment_methods.eq(0).hide();
106			}
107			// If there are none selected, select the first.
108			if (0 === $payment_methods.filter(':checked').length) {
109			$payment_methods.eq(0).prop('checked', true);
110			}
111			// Trigger click event for selected method
112			$payment_methods.filter(':checked').eq(0).trigger('click');
113			// Validate and apply a discount
114			$checkout_form.on('click', '#wpi-apply-discount', this.applyDiscount);
115			// Prevent the checkout form from submitting when hitting enter key in the discount field
116			$checkout_form.on('keypress', '#wpinv_discount_code', function(event) {
117			if (event.keyCode == '13') {
			0 ignored issues – show Complexity Best Practice introduced 2017-06-23 11:56 UTC by Report Bug Copy Issue Report There is no return statement if `event.keyCode == "13"` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
118			return false;
119			}
120			});
121			// Apply the discount when hitting enter key in the discount field instead
122			$checkout_form.on('keyup', '#wpinv_discount_code', function(event) {
123			if (event.keyCode == '13') {
124			$('#wpi-apply-discount', $checkout_form).trigger('click');
125			}
126			});
127			// Remove a discount
128			$(document.body).on('click', '.wpi-discount-remove', this.removeDiscount);
129			},
130			payment_method_selected: function() {
131			if ($('.wpi-payment_methods input.wpi-pmethod').length > 1) {
132			var target_payment_box = $('div.payment_box.' + $(this).attr('ID'));
133			if ($(this).is(':checked') && !target_payment_box.is(':visible')) {
134			$('div.payment_box').filter(':visible').slideUp(250);
135			if ($(this).is(':checked')) {
136			var content = $('div.payment_box.' + $(this).attr('ID')).html();
137			content = content ? content.trim() : '';
138			if (content) {
139			$('div.payment_box.' + $(this).attr('ID')).slideDown(250);
140			}
141			}
142			}
143			} else {
144			$('div.payment_box').show();
145			}
146			$('#wpinv_payment_mode_select').attr('data-gateway', $(this).val());
147			if ($(this).data('button-text')) {
148			$('#wpinv-payment-button').val($(this).data('button-text'));
149			} else {
150			$('#wpinv-payment-button').val($('#wpinv-payment-button').data('value'));
151			}
152			},
153			applyDiscount: function(e) {
			0 ignored issues – show Duplication introduced 2017-07-21 09:25 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
154			e.preventDefault();
155			var $this = $(this),
156			$box = $this.closest('.panel-body'),
157			discount_code = $('#wpinv_discount_code', $box).val(),
158			$msg = $('.wpinv-discount-msg', $box),
159			$msgS = $('.alert-success', $msg),
160			$msgF = $('.alert-error', $msg);
161			if (discount_code == '') {
162			$('#wpinv_discount_code', $box).focus();
163			return false;
164			}
165			var data = {
166			action: 'wpinv_apply_discount',
167			code: discount_code,
168			_nonce: WPInv.nonce
			0 ignored issues – show Bug introduced 2017-06-23 11:56 UTC by Report Bug Copy Issue Report The variable `WPInv` seems to be never declared. If this is a global, consider adding a `/** global: WPInv */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
169			};
170			$('.wpinv_errors').remove();
171			$msg.hide();
172			$msgS.hide().find('.wpi-msg').html('');
173			$msgF.hide().find('.wpi-msg').html('');
174			wpinvBlock($box);
175			$.ajax({
176			type: "POST",
177			data: data,
178			dataType: "json",
179			url: WPInv.ajax_url,
180			xhrFields: {
181			withCredentials: true
182			},
183			success: function(res) {
184			wpinvUnblock($box);
185			var success = false;
186			if (res && typeof res == 'object') {
187			if (res.success) {
188			success = true;
189			jQuery('#wpinv_checkout_cart_form', $this.checkout_form).replaceWith(res.data.html);
190			jQuery('.wpinv-chdeckout-total').text(res.data.total);
191			$('#wpinv_discount_code', $box).val('');
192			//console.log('217 : wpinv_recalculate_taxes()');
193			//wpinv_recalculate_taxes();
194			if (res.data.free) {
195			$('#wpinv_payment_mode_select', $this.checkout_form).hide();
196			gw = 'manual';
			0 ignored issues – show Bug introduced 2017-07-21 09:25 UTC by Report Bug Copy Issue Report The variable `gw` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.gw`. Loading history...
197			} else {
198			$('#wpinv_payment_mode_select', $this.checkout_form).show();
199			gw = $('#wpinv_payment_mode_select', $this.checkout_form).data('gateway');
200			}
201			$('input[name="wpi-gateway"]', $this.checkout_form).val(gw);
202			$(document.body).trigger('wpinv_discount_applied', [res]);
203			}
204			if (res.msg) {
205			$msg.show();
206			if (success) {
207			$msgS.show().find('.wpi-msg').html(res.msg);
208			} else {
209			$msgF.show().find('.wpi-msg').html(res.msg);
210			}
211			}
212			}
213			}
214			}).fail(function(res) {
215			wpinvUnblock($box);
216			if (window.console && window.console.log) {
217			console.log(res);
			0 ignored issues – show Debugging Code introduced 2017-06-23 11:56 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
218			}
219			});
220			return false;
221			},
222			removeDiscount: function(e) {
			0 ignored issues – show Duplication introduced 2017-07-21 09:25 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
223			e.preventDefault();
224			var $this = $(this),
225			$block = $this.closest('#wpinv_checkout_cart_wrap'),
226			discount_code = $this.data('code');
227			if (discount_code == '') {
228			return false;
229			}
230			var data = {
231			action: 'wpinv_remove_discount',
232			code: discount_code,
233			_nonce: WPInv.nonce
			0 ignored issues – show Bug introduced 2017-06-23 11:56 UTC by Report Bug Copy Issue Report The variable `WPInv` seems to be never declared. If this is a global, consider adding a `/** global: WPInv */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
234			};
235			wpinvBlock($block);
236			$.ajax({
237			type: "POST",
238			data: data,
239			dataType: "json",
240			url: WPInv.ajax_url,
241			xhrFields: {
242			withCredentials: true
243			},
244			success: function(res) {
245			if (res && typeof res == 'object') {
246			if (res.success) {
247			jQuery('#wpinv_checkout_cart_form', $this.checkout_form).replaceWith(res.data.html);
248			jQuery('.wpinv-chdeckout-total').text(res.data.total);
249			if (res.data.free) {
250			$('#wpinv_payment_mode_select', $this.checkout_form).hide();
251			gw = 'manual';
			0 ignored issues – show Bug introduced 2017-07-21 09:25 UTC by Report Bug Copy Issue Report The variable `gw` seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using `window.gw`. Loading history...
252			} else {
253			$('#wpinv_payment_mode_select', $this.checkout_form).show();
254			gw = $('#wpinv_payment_mode_select', $this.checkout_form).data('gateway');
255			}
256			$('input[name="wpi-gateway"]', $this.checkout_form).val(gw);
257			//console.log('291 : wpinv_recalculate_taxes()');
258			//wpinv_recalculate_taxes();
259			$(document.body).trigger('wpinv_discount_removed', [res]);
260			}
261			}
262			}
263			}).fail(function(res) {
264			wpinvUnblock($block);
265			if (window.console && window.console.log) {
266			console.log(res);
			0 ignored issues – show Debugging Code introduced 2017-06-23 11:56 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
267			}
268			});
269			return false;
270			},
271			recalculate_taxes: function() {
272			console.log('308 : wpinv_recalculate_taxes()');
			0 ignored issues – show Debugging Code introduced 2017-06-23 11:56 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
273			wpinv_recalculate_taxes();
274			}
275			}
276			WPInv_Checkout.init();
277			});
278
279			function wpinvBlock(el, message) {
280			message = typeof message != 'undefined' && message !== '' ? ' ' + message : '';
281			el.block({
282			message: '<i class="fa fa-refresh fa-spin"></i>' + message,
283			overlayCSS: {
284			background: '#fff',
285			opacity: 0.6
286			},
287			ignoreIfBlocked: true
288			});
289			}
290
291			function wpinvUnblock(el) {
292			el.unblock();
293			}
294
295			function wpinvRemoveQueryVar(url, parameter) {
296			//prefer to use l.search if you have a location/link object
297			var urlparts = url.split('?');
298			var urlparts2 = url.split('&');
299			if (urlparts.length >= 2) {
300			var prefix = encodeURIComponent(parameter) + '=';
301			var pars = urlparts[1].split(/[&;]/g);
302			//reverse iteration as may be destructive
303			for (var i = pars.length; i-- > 0;) {
304			//idiom for string.startsWith
305			if (pars[i].lastIndexOf(prefix, 0) !== -1) {
306			pars.splice(i, 1);
307			}
308			}
309			url = urlparts[0] + (pars.length > 0 ? '?' + pars.join('&') : "");
310			return url;
311			} else if (urlparts2.length >= 2) {
312			var prefix = encodeURIComponent(parameter) + '=';
			0 ignored issues – show Comprehensibility Naming Best Practice introduced 2017-06-23 11:56 UTC by Report Bug Copy Issue Report The variable `prefix` already seems to be declared on line `300`. Consider using another variable name or omitting the `var` keyword. This check looks for variables that are declared in multiple lines. There may be several reasons for this. In the simplest case the variable name was reused by mistake. This may lead to very hard to locate bugs. If you want to reuse a variable for another purpose, consider declaring it at or near the top of your function and just assigning to it subsequently so it is always declared. Loading history...
313			var pars = url.split(/[&;]/g);
			0 ignored issues – show Comprehensibility Naming Best Practice introduced 2017-06-23 11:56 UTC by Report Bug Copy Issue Report The variable `pars` already seems to be declared on line `301`. Consider using another variable name or omitting the `var` keyword. This check looks for variables that are declared in multiple lines. There may be several reasons for this. In the simplest case the variable name was reused by mistake. This may lead to very hard to locate bugs. If you want to reuse a variable for another purpose, consider declaring it at or near the top of your function and just assigning to it subsequently so it is always declared. Loading history...
314			//reverse iteration as may be destructive
315			for (var i = pars.length; i-- > 0;) {
			0 ignored issues – show Comprehensibility Naming Best Practice introduced 2017-06-23 11:56 UTC by Report Bug Copy Issue Report The variable `i` already seems to be declared on line `303`. Consider using another variable name or omitting the `var` keyword. This check looks for variables that are declared in multiple lines. There may be several reasons for this. In the simplest case the variable name was reused by mistake. This may lead to very hard to locate bugs. If you want to reuse a variable for another purpose, consider declaring it at or near the top of your function and just assigning to it subsequently so it is always declared. Loading history...
316			//idiom for string.startsWith
317			if (pars[i].lastIndexOf(prefix, 0) !== -1) {
318			pars.splice(i, 1);
319			}
320			}
321			url = pars.join('&');
322			return url;
323			} else {
324			return url;
325			}
326			}

AyeCode / invoicing

Pull Request — master (#43)

invoice-front.js ➔ jQuery B

Complexity

Size

Duplication

Importance

8 Functions

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like